Allow use of other protocol in CLI #2658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2658 +/- ##
=======================================
Coverage 53.38% 53.38%
=======================================
Files 302 302
Lines 103403 103404 +1
=======================================
+ Hits 55198 55200 +2
+ Misses 48205 48204 -1 ☔ View full report in Codecov by Sentry. |
tzemanovic
previously approved these changes
Feb 20, 2024
Fraccaman
force-pushed
the
fraccaman/allow-http-url-cli
branch
from
a66d4b3 to
7ff35d9
Compare
Fraccaman
force-pushed
the
fraccaman/allow-http-url-cli
branch
2 times, most recently
from
f7a42d4 to
83b8675
Compare
Fraccaman
pushed a commit
that referenced
this pull request
Feb 20, 2024
* origin/fraccaman/allow-http-url-cli: added changelog refactor addresses with protocol use tendermint_rpc::Url instead of TendermintAddress
grarco
previously approved these changes
Feb 20, 2024
Fraccaman
force-pushed
the
fraccaman/allow-http-url-cli
branch
from
83b8675 to
eaf56c7
Compare
Fraccaman
pushed a commit
that referenced
this pull request
Feb 21, 2024
* origin/fraccaman/allow-http-url-cli: added changelog refactor addresses with protocol use tendermint_rpc::Url instead of TendermintAddress
|
@Fraccaman tpc should be tcp in the replace. |
zenodeapp
reviewed
Feb 22, 2024
| fn arg_from_ctx( | ||
| ctx: &ChainContext, | ||
| raw: impl AsRef<str>, | ||
| ) -> Result<Self, String> { | ||
| if raw.as_ref().is_empty() { | ||
| return Ok(ctx.config.ledger.cometbft.rpc.laddr.clone()); | ||
| return Self::from_str( | ||
| &ctx.config.ledger.cometbft.rpc.laddr.to_string().replace("tpc", "http"), |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Allow a user to input http/https protocol when supplying
--nodeor--ledger-addressIndicate on which release or other PRs this topic is based on
Checklist before merging to
draft